GH-37 Implement /withdraw command for physical banknote withdrawal #89

Qbiterv · 2025-10-12T16:07:32Z

No description provided.

… configuration

…k command, and implement paycheck listener

…e dependencies for improved clarity and functionality

gemini-code-assist

Code Review

This pull request introduces a feature for players to withdraw in-game currency as physical items (checks). The implementation is mostly solid, but there are several critical and high-severity issues that need to be addressed. These include a bug that could cause players to lose items, potential data precision loss in the economy, incorrect permission setup, and a bug in argument parsing. I've also included some medium-severity suggestions to improve code quality and consistency.

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawService.java

...onomy-core/src/main/java/com/eternalcode/economy/command/argument/PriceArgumentResolver.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawCommand.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawService.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawTagger.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/EconomyBukkitPlugin.java

...core/src/main/java/com/eternalcode/economy/config/implementation/messages/MessageConfig.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawListener.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawManager.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawService.java

Jakubk15 · 2025-10-12T17:19:28Z

And please, please adjust to Gemini's suggestions!

P1otrulla

Good job, but you need to clean up some things.

Change spigot API for paper and remove this hacks about display name etc.

We use Bukkit#getPlayer... only in utils etc -> use normal instance of server like Server#getPlayer

Add function to block renaming check as i told you on voice chat as we're talking about it.

...leconomy-core/src/main/java/com/eternalcode/economy/command/impl/admin/AdminItemCommand.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawListener.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawCommand.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawManager.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/EconomyPermissionConstant.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawCommand.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawTagger.java

...n/java/com/eternalcode/economy/config/implementation/messages/MessagePaycheckSubSection.java

...aleconomy-core/src/main/java/com/eternalcode/economy/config/implementation/PluginConfig.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawListener.java

…plement new withdraw functionality + Support blocking anvil interactions

…ment parsing, and enhance admin commands

…m setup logic, and improve inventory interaction messages

… to ensure prices are greater than 0.09

…ceArgumentResolver for consistency across commands

…ter readability

…R if currency item is AIR

eternaleconomy-core/build.gradle.kts

...onomy-core/src/main/java/com/eternalcode/economy/command/argument/PriceArgumentResolver.java

...core/src/main/java/com/eternalcode/economy/config/implementation/messages/MessageConfig.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawItemService.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawMessageConfig.java

...-core/src/main/java/com/eternalcode/economy/withdraw/controller/WithdrawAnvilController.java

P1otrulla

Zrób reoznaczenie mnie jak skaczysz robić tego prka

eternaleconomy-api/build.gradle.kts

eternaleconomy-core/build.gradle.kts

…eImpl class for banknote handling. Add ConfigItem object to handle withdraw item properly

…figItem for better item handling and improve code readability

… of custom model data

eternaleconomy-api/build.gradle.kts

eternaleconomy-core/src/main/java/com/eternalcode/economy/EconomyBukkitPlugin.java

...onomy-core/src/main/java/com/eternalcode/economy/command/argument/PriceArgumentResolver.java

...core/src/main/java/com/eternalcode/economy/config/implementation/messages/MessageConfig.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawItemServiceImpl.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawService.java

…h MoneyFormatArgument for improved money value parsing

…dability and consistency

eternaleconomy-core/src/main/java/com/eternalcode/economy/config/item/ConfigItem.java

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawItemServiceImpl.java

imDMK

Good job

CitralFlo

Rollback changes regarding Argument

Qbiterv added 3 commits October 11, 2025 19:44

Implement basic of paycheck management system with admin commands and…

b5d1c21

… configuration

Enhance paycheck system: add price argument resolver, improve paychec…

2ec3945

…k command, and implement paycheck listener

Refactor paycheck system to withdraw system: rename classes and updat…

57297af

…e dependencies for improved clarity and functionality

Qbiterv requested a review from a team as a code owner October 12, 2025 16:07

CitralFlo linked an issue Oct 12, 2025 that may be closed by this pull request

Withdraw physical currency using /withdraw command #37

Open

Qbiterv changed the title ~~Physical withdraw~~ GH-37 Physical withdrawal Oct 12, 2025

CitralFlo requested review from CitralFlo, Jakubk15, P1otrulla, Rollczi, imDMK, noyzys and vLuckyyy October 12, 2025 16:09

gemini-code-assist bot reviewed Oct 12, 2025

View reviewed changes

Jakubk15 approved these changes Oct 12, 2025

View reviewed changes

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawManager.java Outdated Show resolved Hide resolved

eternaleconomy-core/src/main/java/com/eternalcode/economy/withdraw/WithdrawService.java Outdated Show resolved Hide resolved

P1otrulla requested changes Oct 12, 2025

View reviewed changes

vLuckyyy requested changes Oct 12, 2025

View reviewed changes

Qbiterv added 7 commits October 13, 2025 02:49

Refactor withdraw system: rename classes, update dependencies, and im…

a6c2134

…plement new withdraw functionality + Support blocking anvil interactions

Refactor withdraw system: update message handling, improve price argu…

632c26b

…ment parsing, and enhance admin commands

Refactor withdraw system: update plugin metadata handling, adjust ite…

dc22d8b

…m setup logic, and improve inventory interaction messages

Fix price validation logic in PriceArgumentResolver: update threshold…

de005b7

… to ensure prices are greater than 0.09

Refactor command argument handling: update amount argument to use Pri…

e84550c

…ceArgumentResolver for consistency across commands

Refactor AdminSetCommand: improve method parameter formatting for bet…

e558053

…ter readability

Refactor WithdrawItemService: ensure default item type is set to PAPE…

292a847

…R if currency item is AIR

imDMK reviewed Oct 14, 2025

View reviewed changes

P1otrulla requested review from P1otrulla, imDMK and vLuckyyy October 14, 2025 21:42

P1otrulla requested changes Oct 14, 2025

View reviewed changes

eternaleconomy-api/build.gradle.kts Outdated Show resolved Hide resolved

eternaleconomy-core/build.gradle.kts Outdated Show resolved Hide resolved

Qbiterv added 2 commits October 16, 2025 00:14

Implement WithdrawItemService interface and create WithdrawItemServic…

2aba885

…eImpl class for banknote handling. Add ConfigItem object to handle withdraw item properly

Refactor PluginConfig and command classes: replace ItemStack with Con…

40bf52c

…figItem for better item handling and improve code readability

Qbiterv requested a review from P1otrulla October 15, 2025 22:16

Refactor WithdrawService: update texture assignment to handle absence…

94d83d2

… of custom model data

Qbiterv self-assigned this Oct 16, 2025

CitralFlo requested changes Oct 17, 2025

View reviewed changes

Refactor command argument handling: replace PriceArgumentResolver wit…

55aa9b6

…h MoneyFormatArgument for improved money value parsing

vLuckyyy removed the request for review from noyzys October 17, 2025 22:36

P1otrulla removed their request for review October 18, 2025 14:35

Refactor message formatting: streamline chat notices for improved rea…

df22aa5

…dability and consistency

vLuckyyy changed the title ~~GH-37 Physical withdrawal~~ GH-37 Implement /withdraw command for physical banknote withdrawal Oct 20, 2025

CitralFlo requested a review from P1otrulla October 24, 2025 11:20

Qbiterv requested a review from CitralFlo October 24, 2025 18:19

imDMK requested changes Oct 30, 2025

View reviewed changes

Review. Use proper paper-api loader, fix multiple bug's.

4b312cd

vLuckyyy requested a review from imDMK November 4, 2025 15:49

Fix tabulation. Remove useless changes.

43aed79

imDMK approved these changes Nov 5, 2025

View reviewed changes

P1otrulla approved these changes Nov 8, 2025

View reviewed changes

CitralFlo requested changes Nov 30, 2025

View reviewed changes

Uh oh!

GH-37 Implement /withdraw command for physical banknote withdrawal #89

Are you sure you want to change the base?

GH-37 Implement /withdraw command for physical banknote withdrawal #89

Conversation

Qbiterv commented Oct 12, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jakubk15 commented Oct 12, 2025

Uh oh!

P1otrulla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

P1otrulla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

imDMK left a comment

Choose a reason for hiding this comment

Uh oh!

CitralFlo left a comment

Choose a reason for hiding this comment